Skip to content

[Auth] 닉네임 중복 체크 API 응답형식 변경#109

Merged
Creamcheesepie merged 1 commit into
mainfrom
refactor/#108
Dec 17, 2025
Merged

[Auth] 닉네임 중복 체크 API 응답형식 변경#109
Creamcheesepie merged 1 commit into
mainfrom
refactor/#108

Conversation

@larama-C
Copy link
Copy Markdown
Collaborator

@larama-C larama-C commented Dec 16, 2025 •
edited
Loading

🔗 관련 이슈

관련된 이슈 번호를 연결해주세요.
Close #이슈번호 를 쓰면 PR merge 시 자동으로 close 됩니다.

🚀 PR 개요

이 PR이 어떤 변경을 포함하고 있는지 간단히 설명해주세요.

  • 닉네임 중복 체크 시 응답값에 true, false가 아닌 통과시 success 중복된 닉네임이 있을경우 따로 지정한 에러코드를 통해 응답값을 반환합니다.

📌 변경 사항

주요 변경 내용을 체크리스트 형태로 정리해주세요.

  • 기능 추가
  • 버그 수정
  • 리팩터링
  • 문서 업데이트
  • 테스트 추가/수정

🧪 테스트 방법

변경된 내용을 어떻게 테스트했는지 구체적으로 적어주세요.

📸 스크린샷 (선택)

UI 변경 또는 시각적으로 확인할 수 있는 변경이 있다면 첨부해주세요.

⚠️ 참고 사항

리뷰어가 알아야 할 사항이 있다면 자유롭게 작성해주세요.

@larama-C larama-C self-assigned this Dec 16, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 16, 2025

Test Results

1 tests  ±0   1 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit d057b46. ± Comparison against base commit 697d54e.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 16, 2025

⭐ JaCoCo Coverage

Line Coverage: 5.67%

📄 Coverage Details

Overall Line Coverage: 5.63% (119 covered / 2112 lines)

Package Summary (lowest first)
Package Line % Covered Missed
com/back/web7_9_codecrete_be/domain/chats/controller 0.00% 0 0
com/back/web7_9_codecrete_be/domain/location/service 0.00% 0 25
com/back/web7_9_codecrete_be/domain/chats/service 0.00% 0 0
com/back/web7_9_codecrete_be/domain/plans/controller 0.00% 0 33
com/back/web7_9_codecrete_be/domain/location/controller 0.00% 0 4
com/back/web7_9_codecrete_be/global/rsData 0.00% 0 11
com/back/web7_9_codecrete_be/domain/location/entity 0.00% 0 0
com/back/web7_9_codecrete_be/global/scheduler 0.00% 0 3
com/back/web7_9_codecrete_be/domain/auth/entity 0.00% 0 0
com/back/web7_9_codecrete_be/domain/auth/service 0.00% 0 73
com/back/web7_9_codecrete_be/domain/plans/service 0.00% 0 311
com/back/web7_9_codecrete_be/global/initData 0.00% 0 26
com/back/web7_9_codecrete_be/domain/users/controller 0.00% 0 20
com/back/web7_9_codecrete_be/domain/email/entity 0.00% 0 6
com/back/web7_9_codecrete_be/domain/users/service 0.00% 0 59
com/back/web7_9_codecrete_be/domain/auth/controller 0.00% 0 20
com/back/web7_9_codecrete_be/domain/concerts/controller 0.00% 0 22
com/back/web7_9_codecrete_be/domain/artists/controller 0.00% 0 12
com/back/web7_9_codecrete_be/global/aspect 0.00% 0 4
com/back/web7_9_codecrete_be/global/wikidata 0.36% 1 279
com/back/web7_9_codecrete_be/domain/artists/service 0.86% 3 345
com/back/web7_9_codecrete_be/global/musicbrainz 0.99% 1 100
com/back/web7_9_codecrete_be/domain/email/service 1.92% 1 51
com/back/web7_9_codecrete_be/domain/concerts/entity 4.76% 3 60
com/back/web7_9_codecrete_be/domain/concerts/service 6.80% 21 288
com/back/web7_9_codecrete_be/domain/artists/entity 9.09% 3 30
com/back/web7_9_codecrete_be/global/rq 12.90% 4 27
com/back/web7_9_codecrete_be/domain/users/entity 22.86% 8 27
com/back/web7_9_codecrete_be/domain/plans/entity 24.42% 21 65
com/back/web7_9_codecrete_be/global/security 26.36% 29 81
com/back/web7_9_codecrete_be/global/storage 33.33% 1 2
com/back/web7_9_codecrete_be/global/spotify 35.71% 5 9
com/back/web7_9_codecrete_be/domain/chats/entity 100.00% 1 0
com/back/web7_9_codecrete_be/global/doc 100.00% 17 0
Lowest Covered Classes (Top 20)
Class Line % Covered Missed
com.back.web7_9_codecrete_be.domain.plans.service.PlanService 0.00% 0 311
com.back.web7_9_codecrete_be.domain.users.service.UserService 0.00% 0 55
com.back.web7_9_codecrete_be.domain.concerts.service.ConcertService 0.00% 0 48
com.back.web7_9_codecrete_be.domain.auth.service.AuthService 0.00% 0 46
com.back.web7_9_codecrete_be.domain.artists.service.ArtistService 0.00% 0 44
com.back.web7_9_codecrete_be.domain.concerts.entity.Concert 0.00% 0 38
com.back.web7_9_codecrete_be.global.security.JwtTokenProvider 0.00% 0 37
com.back.web7_9_codecrete_be.domain.plans.entity.Schedule 0.00% 0 36
com.back.web7_9_codecrete_be.domain.plans.controller.PlanController 0.00% 0 33
com.back.web7_9_codecrete_be.domain.users.entity.User 0.00% 0 27
com.back.web7_9_codecrete_be.domain.auth.service.TokenService 0.00% 0 27
com.back.web7_9_codecrete_be.global.initData.BaseInitData 0.00% 0 26
com.back.web7_9_codecrete_be.domain.artists.entity.Artist 0.00% 0 25
com.back.web7_9_codecrete_be.domain.users.controller.UserController 0.00% 0 20
com.back.web7_9_codecrete_be.domain.auth.controller.AuthController 0.00% 0 20
com.back.web7_9_codecrete_be.domain.plans.entity.Plan 0.00% 0 18
com.back.web7_9_codecrete_be.domain.concerts.controller.ConcertController 0.00% 0 14
com.back.web7_9_codecrete_be.domain.location.service.TmapService 0.00% 0 13
com.back.web7_9_codecrete_be.domain.concerts.service.KopisApiService$TicketPrice 0.00% 0 13
com.back.web7_9_codecrete_be.domain.location.service.KakaoLocalService 0.00% 0 12
Changed Classes (from this PR)
Source (PR) Class Prefix Line % Covered Missed
src/main/java/com/back/web7_9_codecrete_be/domain/auth/service/AuthService.java com.back.web7_9_codecrete_be.domain.auth.service.AuthService 0.00% 0 46
src/main/java/com/back/web7_9_codecrete_be/domain/auth/controller/AuthController.java com.back.web7_9_codecrete_be.domain.auth.controller.AuthController 0.00% 0 20

🔗 Full HTML report: See artifact jacoco-full-html on this run → https://github.com/prgrms-web-devcourse-final-project/WEB7_9_codecrete_BE/actions/runs/20272664699

ys0221
ys0221 approved these changes Dec 17, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ys0221 ys0221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

Creamcheesepie
Creamcheesepie approved these changes Dec 17, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Creamcheesepie Creamcheesepie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로직이 결합도를 낮추는 쪽으로 바뀌었는데 좋은 것 같습니다.

tobbot16
tobbot16 approved these changes Dec 17, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@tobbot16 tobbot16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

@Creamcheesepie Creamcheesepie merged commit 84ec0c1 into main Dec 17, 2025
2 checks passed
@Creamcheesepie Creamcheesepie deleted the refactor/#108 branch December 17, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobbot16 tobbot16 tobbot16 approved these changes

@Creamcheesepie Creamcheesepie Creamcheesepie approved these changes

@ys0221 ys0221 ys0221 approved these changes

@heygeeji heygeeji heygeeji approved these changes

Assignees

@larama-C larama-C

Labels

Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Auth] 닉네임 중복 체크 api 응답값 로직 수정

5 participants

@larama-C @tobbot16 @Creamcheesepie @ys0221 @heygeeji